linux-kernel - Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d80b11c-99db-432d-a9ff-d9e2a7b463bb@amd.com>
Date: Tue, 20 May 2025 09:28:05 -0600
From: Alex Hung <alex.hung@....com>
To: James <bold.zone2373@...tmail.com>,
 Harry Wentland <harry.wentland@....com>, sunpeng.li@....com,
 Rodrigo Siqueira <siqueira@...lia.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 airlied@...il.com, simona@...ll.ch, alvin.lee2@....com,
 zaeem.mohamed@....com, Shuah Khan <skhan@...uxfoundation.org>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for
 dc_stream_remove_writeback()



On 5/19/25 20:06, James wrote:
> 
> 
> On Mon, May 5, 2025, at 9:02 AM, Alex Hung wrote:
>> Reviewed-by: Alex Hung <alex.hung@....com>
>>
>> On 5/3/25 15:18, James Flowers wrote:
>>> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>>>
>>> Signed-off-by: James Flowers <bold.zone2373@...tmail.com>
>>> ---
>>> V1 -> V2: Corrected checkpatch warnings and errors
>>>
>>>    drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>>>    1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> index e6e41678525f..b883fb24fa12 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>>>    	return true;
>>>    }
>>>    
>>> +/**
>>> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
>>> + * @dc: Display core control structure.
>>> + * @stream: Display core stream state.
>>> + * @dwb_pipe_inst: Display writeback pipe.
>>> + *
>>> + * Return: returns true on success, false otherwise.
>>> + */
>>>    bool dc_stream_remove_writeback(struct dc *dc,
>>>    		struct dc_stream_state *stream,
>>>    		uint32_t dwb_pipe_inst)
> 
> Hi,
> 
> I am just following up on this to see if it’s been applied, or if any adjustments are still needed.

It's in amd-staging-drm-next: 
https://gitlab.freedesktop.org/agd5f/linux/-/commit/04abe7201d51a094d0edd3e00399a8afa2cd2d4f

> 
> Best regards,
> James Flowers