linux-kernel - Re: [PATCH] power: reset: qcom-pon: Rename variables to use generic naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xyhqu7bw3kqlkl5q3q3hexceq2irm4vru6lfspsnpmxkhp6vuc@jpqtvyke5aec>
Date: Tue, 20 May 2025 18:44:33 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Taeyoung Kwon <xoduddk12345@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Taeyoung Kwon <Taeyoung.Kwon@...it.com>
Subject: Re: [PATCH] power: reset: qcom-pon: Rename variables to use generic
 naming

On Tue, May 20, 2025 at 02:35:50PM +0000, Taeyoung Kwon wrote:
> As my company email adds a signature automatically,
> I am sending this from my personal Gmail account
> 
> ---
> The qcom-pon driver was originally implemented for the PM8916 PMIC, and
> as a result, several internal variable names still refer to 'pm8916'.
> However, the driver has since been extended to support other PMICs as
> well.
> 
> This patch renames those variables to use more generic and consistent
> names, improving clarity and reducing confusion for non-PM8916 devices.
> 
> Signed-off-by: Taeyoung Kwon <Taeyoung.Kwon@...it.com>

Now your SoB doesn't match your From address. Please move your
explanation under the '---' line and instead add the 'From: Your Name
<company@...ress>' as the first line.

The patch LGTM.

> ---
>  drivers/power/reset/qcom-pon.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 

-- 
With best wishes
Dmitry