linux-kernel - Re: [PATCH v2 2/2] vt: add VT_GETCONSIZECSRPOS to retrieve console size and cursor position

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <p7p83sq1-4ro2-o924-s9o2-30spr74n076o@syhkavp.arg>
Date: Tue, 20 May 2025 12:34:38 -0400 (EDT)
From: Nicolas Pitre <nico@...xnic.net>
To: Jiri Slaby <jirislaby@...nel.org>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] vt: add VT_GETCONSIZECSRPOS to retrieve console
 size and cursor position

On Thu, 15 May 2025, Nicolas Pitre wrote:

> On Thu, 15 May 2025, Jiri Slaby wrote:
> 
> > On 14. 05. 25, 21:42, Nicolas Pitre wrote:
> > > +#define VT_GETCONSIZECSRPOS 0x5610  /* get console size and cursor position
> > > */
> > 
> > Can we define that properly as
> >   _IOR(0x56, 0x10, struct vt_consizecsrpos)
> > ? Note this would still differ from "conflicting":
> > #define VIDIOC_G_FBUF            _IOR('V', 10, struct v4l2_framebuffer)
> 
> Similarly as the reason above: given that no other definitions in that 
> file use the _IO*() scheme for historical reasons, it is preferable to 
> follow what's already there to avoid unsuspected confusion. The VT layer 
> is pretty much unlykely to grow many additional ioctls in the 
> foreseeable future so I'd lean towards keeping things simple and in line 
> with the existing code.

OK... I found precedents for a mixed sheme in 
include/uapi/asm-generic/ioctls.h. Therefore I give in.


Nicolas