linux-kernel - Re: [PATCH v2] x86/bugs: Restructure ITS mitigation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520165716.5rfmxe7gqizy55zh@desk>
Date: Tue, 20 May 2025 09:57:24 -0700
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: David Kaplan <david.kaplan@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/bugs: Restructure ITS mitigation

On Tue, May 20, 2025 at 06:48:26PM +0200, Borislav Petkov wrote:
> On Tue, May 20, 2025 at 09:32:21AM -0700, Pawan Gupta wrote:
> > Index 1 (which is now ITS_MITIGATION_AUTO) is missing. I understand AUTO is
> > a temporary state, and it may not be necessary to define a string for it.
> > But, assigning an empty string, or an error message would make this obvious
> > for a future reader.
> 
> Yeah, this AUTO gets overwritten and the other AUTOs don't have strings too.
> 
> We can fix that after the MW if you think it is important but from what
> I looked, all the AUTO settings get overwritten as AUTO means, user didn't
> make any decision here so it is left to the kernel to make it.

As long as AUTO setting is overwritten it is fine.