linux-kernel - Re: [PATCH v9 03/10] drm/sched: add device name to the drm_sched_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9794bcf-6e00-4900-ba1e-cc8b223bfbb9@damsy.net>
Date: Tue, 20 May 2025 18:56:54 +0200
From: Pierre-Eric Pelloux-Prayer <pierre-eric@...sy.net>
To: Danilo Krummrich <dakr@...nel.org>,
 Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>
Cc: Matthew Brost <matthew.brost@...el.com>,
 Philipp Stanner <phasta@...nel.org>,
 Christian König <ckoenig.leichtzumerken@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Christian König <christian.koenig@....com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 03/10] drm/sched: add device name to the
 drm_sched_process_job event



Le 19/05/2025 à 17:34, Danilo Krummrich a écrit :
> On Thu, Apr 24, 2025 at 10:38:15AM +0200, Pierre-Eric Pelloux-Prayer wrote:
>> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
>> index f56e77e7f6d0..713df3516a17 100644
>> --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
>> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
>> @@ -42,6 +42,7 @@ DECLARE_EVENT_CLASS(drm_sched_job,
>>   			     __field(uint64_t, id)
>>   			     __field(u32, job_count)
>>   			     __field(int, hw_job_count)
>> +			     __string(dev, dev_name(sched_job->sched->dev))
> 
> Using the sched_job->sched pointer here and in other trace events implies that
> the trace event must not be called before the sched_job->sched has been set,
> i.e. in drm_sched_job_arm().
> 
> Please document this for the corresponding trace events.

This is not a new requirement as sched and s_fence were already used by the trace events.

Still it's a good idea to document this, so I'll update the comment added in the documentation patch.

Thanks,
Pierre-Eric