linux-kernel - Re: [PATCH 06/28] mm, swap: rearrange swap cluster definition and helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMgjq7CspZEc77Vv4ZTqNbcx3dYgdj2bOz1QHS42w=nYJZeDDQ@mail.gmail.com>
Date: Tue, 20 May 2025 11:50:30 +0800
From: Kairui Song <ryncsn@...il.com>
To: Barry Song <21cnbao@...il.com>
Cc: akpm@...ux-foundation.org, baohua@...nel.org, 
	baolin.wang@...ux.alibaba.com, bhe@...hat.com, chrisl@...nel.org, 
	david@...hat.com, hannes@...xchg.org, hughd@...gle.com, 
	kaleshsingh@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	nphamcs@...il.com, ryan.roberts@....com, shikemeng@...weicloud.com, 
	tim.c.chen@...ux.intel.com, willy@...radead.org, ying.huang@...ux.alibaba.com, 
	yosryahmed@...gle.com
Subject: Re: [PATCH 06/28] mm, swap: rearrange swap cluster definition and helpers

On Mon, May 19, 2025 at 2:26 PM Barry Song <21cnbao@...il.com> wrote:
>
> > From: Kairui Song <kasong@...cent.com>
>
> > @@ -889,10 +849,8 @@ static unsigned long cluster_alloc_swap_entry(struct swap_info_struct *si, int o
> >               /* Serialize HDD SWAP allocation for each device. */
> >               spin_lock(&si->global_cluster_lock);
> >               offset = si->global_cluster->next[order];
> > -             if (offset == SWAP_ENTRY_INVALID)
> > -                     goto new_cluster;
>
> We are implicitly dropping this. Does it mean the current code is wrong?
> Do we need some clarification about this?

Sorry, my bad, this change has nothing to do with this commit, I'll
drop this change in the next version.

>
> >
> > -             ci = lock_cluster(si, offset);
> > +             ci = swap_lock_cluster(si, offset);
> >               /* Cluster could have been used by another order */
> >               if (cluster_is_usable(ci, order)) {
> >                       if (cluster_is_empty(ci))
>
> Thanks
> Barry