linux-kernel - RE: [PATCH] scsi: fnic: Replace memset with eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB5896F06178A5DEDFACE522E4C39FA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Tue, 20 May 2025 18:12:27 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Chen Ni <nichen@...as.ac.cn>, "Satish Kharat (satishkh)"
	<satishkh@...co.com>, "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: fnic: Replace memset with eth_zero_addr

On Monday, May 19, 2025 1:55 AM, Chen Ni <nichen@...as.ac.cn> wrote:
>
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
> drivers/scsi/fnic/fip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
> index 6e7c0b00eb41..19395e2aee44 100644
> --- a/drivers/scsi/fnic/fip.c
> +++ b/drivers/scsi/fnic/fip.c
> @@ -200,7 +200,7 @@ void fnic_fcoe_start_fcf_discovery(struct fnic *fnic)
> return;
> }
>
> -     memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
> +     eth_zero_addr(iport->selected_fcf.fcf_mac);
>
> pdisc_sol = (struct fip_discovery *) frame;
> *pdisc_sol = (struct fip_discovery) {
> @@ -588,12 +588,12 @@ void fnic_common_fip_cleanup(struct fnic *fnic)
> if (!is_zero_ether_addr(iport->fpma))
> vnic_dev_del_addr(fnic->vdev, iport->fpma);
>
> -     memset(iport->fpma, 0, ETH_ALEN);
> +     eth_zero_addr(iport->fpma);
> iport->fcid = 0;
> iport->r_a_tov = 0;
> iport->e_d_tov = 0;
> -     memset(fnic->iport.fcfmac, 0, ETH_ALEN);
> -     memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
> +     eth_zero_addr(fnic->iport.fcfmac);
> +     eth_zero_addr(iport->selected_fcf.fcf_mac);
> iport->selected_fcf.fcf_priority = 0;
> iport->selected_fcf.fka_adv_period = 0;
> iport->selected_fcf.ka_disabled = 0;
> --
> 2.25.1
>
>

Hi Chen,

Thanks for these changes.
They look good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan