linux-kernel - Re: [PATCH] io_uring/cmd: axe duplicate io_uring_cmd_import_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174777343432.778148.1451499189557344108.b4-ty@kernel.dk>
Date: Tue, 20 May 2025 14:37:14 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Pavel Begunkov <asml.silence@...il.com>, 
 Caleb Sander Mateos <csander@...estorage.com>
Cc: io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring/cmd: axe duplicate
 io_uring_cmd_import_fixed_vec() declaration


On Tue, 20 May 2025 13:33:36 -0600, Caleb Sander Mateos wrote:
> io_uring_cmd_import_fixed_vec() is declared in both
> include/linux/io_uring/cmd.h and io_uring/uring_cmd.h. The declarations
> are identical (if redundant) for CONFIG_IO_URING=y. But if
> CONFIG_IO_URING=N, include/linux/io_uring/cmd.h declares the function as
> static inline while io_uring/uring_cmd.h declares it as extern. This
> causes linker errors if the declaration in io_uring/uring_cmd.h is used.
> 
> [...]

Applied, thanks!

[1/1] io_uring/cmd: axe duplicate io_uring_cmd_import_fixed_vec() declaration
      commit: f1774d9d4e104639a9122bde3b1fe58a0c0dcde7

Best regards,
-- 
Jens Axboe