linux-kernel - Re: [PATCH 08/15] platform/x86/intel/pmt: Add PMT Discovery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43b6f7e95a4ca1ff34798c668731a85178b15474.camel@linux.intel.com>
Date: Tue, 20 May 2025 13:59:30 -0700
From: "David E. Box" <david.e.box@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 platform-driver-x86@...r.kernel.org, 	srinivas.pandruvada@...ux.intel.com,
 Andy Shevchenko	 <andriy.shevchenko@...ux.intel.com>, tony.luck@...el.com, 
	xi.pardee@...ux.intel.com, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 08/15] platform/x86/intel/pmt: Add PMT Discovery driver

On Tue, 2025-05-20 at 17:32 +0300, Ilpo Järvinen wrote:
> On Wed, 30 Apr 2025, David E. Box wrote:

...

> > +/* Get the discovery table and use it to get the feature table */
> > +static int pmt_features_discovery(struct pmt_features_priv *priv,
> > +				  struct feature *feature,
> > +				  struct intel_vsec_device *ivdev,
> > +				  int idx)
> > +{
> > +	struct feature_discovery_table disc_tbl = {}; /* For static
> > analyzers */
> 
> I suppose you meant the initialization is for static analyzers but that's 
> not what the comment now reads.

I'll change it to say "Zero-init to avoid false positives in static analysis
tools"

Ack on the other comments. Thanks.

David