linux-kernel - Re: [PATCH v2 0/8] Introduce HDP support for STM32MP platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174777533581.1435243.228426835513916964.robh@kernel.org>
Date: Tue, 20 May 2025 16:09:20 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Clément Le Goffic <clement.legoffic@...s.st.com>
Cc: linux-arm-kernel@...ts.infradead.org, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Bartosz Golaszewski <brgl@...ev.pl>, 
 linux-stm32@...md-mailman.stormreply.com, devicetree@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/8] Introduce HDP support for STM32MP platforms


On Tue, 20 May 2025 17:02:27 +0200, Clément Le Goffic wrote:
> This patch series introduces the Hardware Debug Port (HDP) support for
> STM32MP platforms.
> 
> It includes the addition of device tree bindings, the HDP driver,
> and updates to the device tree files for STM32MP13, STM32MP15,
> and STM32MP25 SoCs.
> The series also updates the MAINTAINERS file to include myself as the
> maintainer for the STM32 HDP driver and adds the necessary
> pinmux configurations for HDP pins on STM32MP157C-DK2 as example.
> 
> Signed-off-by: Clément Le Goffic <clement.legoffic@...s.st.com>
> ---
> Changes in v2:
> - Remove bindings header files with function name as #define
> - Add match_data with function name for three compatible:
>   "st,stm32mp131-hdp", "st,stm32mp151-hdp" and "st,stm32mp251-hdp".
> - Rework a bit the driver to use match_data.
> - Remove the use of `dev_err_probe(` in the resume ops.
> - Remove `MODULE_ALIAS(`.
> - Remove the vertical bar in bindings description paragraph.
> - Fix an error in the `pinctrl-0` parameter of the binding example, it
>   was refering a node that wasn't existing.
> - Use uppercase pin names.
> - Link to v1: https://lore.kernel.org/r/20250225-hdp-upstream-v1-0-9d049c65330a@foss.st.com
> 
> ---
> Clément Le Goffic (8):
>       dt-bindings: pinctrl: stm32: Introduce HDP
>       pinctrl: stm32: Introduce HDP driver
>       MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer
>       ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13
>       ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15
>       ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25
>       ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node
>       ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board
> 
>  .../bindings/pinctrl/st,stm32-pinctrl-hdp.yaml     | 188 ++++++
>  MAINTAINERS                                        |   6 +
>  arch/arm/boot/dts/st/stm32mp131.dtsi               |   6 +
>  arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi        |  25 +
>  arch/arm/boot/dts/st/stm32mp151.dtsi               |   7 +
>  arch/arm/boot/dts/st/stm32mp157c-dk2.dts           |   6 +
>  arch/arm64/boot/dts/st/stm32mp251.dtsi             |   7 +
>  drivers/pinctrl/stm32/Kconfig                      |  14 +
>  drivers/pinctrl/stm32/Makefile                     |   1 +
>  drivers/pinctrl/stm32/pinctrl-stm32-hdp.c          | 736 +++++++++++++++++++++
>  10 files changed, 996 insertions(+)
> ---
> base-commit: 09fac5c576bbff764dddf2baca0038b359376fd8
> change-id: 20250224-hdp-upstream-622e5da14a9f
> 
> Best regards,
> --
> Clément Le Goffic <clement.legoffic@...s.st.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 09fac5c576bbff764dddf2baca0038b359376fd8

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/st/' for 20250520-hdp-upstream-v2-0-53f6b8b5ffc8@...s.st.com:

arch/arm/boot/dts/st/ste-snowball.dtb: / (calaosystems,snowball-a9500): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
	from schema $id: http://devicetree.org/schemas/root-node.yaml#
arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dtb: /soc/gpio@...0e100: failed to match any schema with compatible: ['stericsson,db8500-gpio', 'st,nomadik-gpio']