lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202505210557.EpJig9BQ-lkp@intel.com>
Date: Wed, 21 May 2025 05:43:03 +0800
From: kernel test robot <lkp@...el.com>
To: Ai Chao <aichao@...inos.cn>, johannes@...solutions.net, perex@...ex.cz,
	tiwai@...e.com, shengjiu.wang@...il.com, Xiubo.Lee@...il.com,
	festevam@...il.com, nicoleotsuka@...il.com, lgirdwood@...il.com,
	broonie@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
	kernel@...gutronix.de, jbrunet@...libre.com,
	neil.armstrong@...aro.org, khilman@...libre.com,
	martin.blumenstingl@...glemail.com, srinivas.kandagatla@...aro.org,
	kuninori.morimoto.gx@...esas.com, zhangzekun11@...wei.com,
	krzysztof.kozlowski@...aro.org, ckeepax@...nsource.cirrus.com,
	drhodes@...nsource.cirrus.com, alexey.klimov@...aro.org
Cc: oe-kbuild-all@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 4/6] ASoC: meson: Use helper function
 for_each_child_of_node_scoped()

Hi Ai,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus wireless-next/main wireless/main linus/master v6.15-rc7 next-20250516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ai-Chao/ASoC-ppc-Use-helper-function-for_each_child_of_node_scoped/20250520-171556
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20250520091131.4150248-5-aichao%40kylinos.cn
patch subject: [PATCH 4/6] ASoC: meson: Use helper function for_each_child_of_node_scoped()
config: arc-randconfig-002-20250521 (https://download.01.org/0day-ci/archive/20250521/202505210557.EpJig9BQ-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250521/202505210557.EpJig9BQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505210557.EpJig9BQ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/sound/soc.h:15,
                    from sound/soc/meson/meson-card-utils.c:8:
   sound/soc/meson/meson-card-utils.c: In function 'meson_card_set_be_link':
>> sound/soc/meson/meson-card-utils.c:166:71: error: 'np' undeclared (first use in this function); did you mean 'up'?
     166 |                 dev_err(card->dev, "error setting %pOFn link name\n", np);
         |                                                                       ^~
   include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                                     ^~~~~~~~~~~
   sound/soc/meson/meson-card-utils.c:166:17: note: in expansion of macro 'dev_err'
     166 |                 dev_err(card->dev, "error setting %pOFn link name\n", np);
         |                 ^~~~~~~
   sound/soc/meson/meson-card-utils.c:166:71: note: each undeclared identifier is reported only once for each function it appears in
     166 |                 dev_err(card->dev, "error setting %pOFn link name\n", np);
         |                                                                       ^~
   include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                                     ^~~~~~~~~~~
   sound/soc/meson/meson-card-utils.c:166:17: note: in expansion of macro 'dev_err'
     166 |                 dev_err(card->dev, "error setting %pOFn link name\n", np);
         |                 ^~~~~~~


vim +166 sound/soc/meson/meson-card-utils.c

aa9c3b7273a58b Jerome Brunet     2020-02-13  134  
aa9c3b7273a58b Jerome Brunet     2020-02-13  135  int meson_card_set_be_link(struct snd_soc_card *card,
aa9c3b7273a58b Jerome Brunet     2020-02-13  136  			   struct snd_soc_dai_link *link,
aa9c3b7273a58b Jerome Brunet     2020-02-13  137  			   struct device_node *node)
aa9c3b7273a58b Jerome Brunet     2020-02-13  138  {
aa9c3b7273a58b Jerome Brunet     2020-02-13  139  	struct snd_soc_dai_link_component *codec;
aa9c3b7273a58b Jerome Brunet     2020-02-13  140  	int ret, num_codecs;
aa9c3b7273a58b Jerome Brunet     2020-02-13  141  
aa9c3b7273a58b Jerome Brunet     2020-02-13  142  	num_codecs = of_get_child_count(node);
aa9c3b7273a58b Jerome Brunet     2020-02-13  143  	if (!num_codecs) {
aa9c3b7273a58b Jerome Brunet     2020-02-13  144  		dev_err(card->dev, "be link %s has no codec\n",
aa9c3b7273a58b Jerome Brunet     2020-02-13  145  			node->full_name);
aa9c3b7273a58b Jerome Brunet     2020-02-13  146  		return -EINVAL;
aa9c3b7273a58b Jerome Brunet     2020-02-13  147  	}
aa9c3b7273a58b Jerome Brunet     2020-02-13  148  
aa9c3b7273a58b Jerome Brunet     2020-02-13  149  	codec = devm_kcalloc(card->dev, num_codecs, sizeof(*codec), GFP_KERNEL);
aa9c3b7273a58b Jerome Brunet     2020-02-13  150  	if (!codec)
aa9c3b7273a58b Jerome Brunet     2020-02-13  151  		return -ENOMEM;
aa9c3b7273a58b Jerome Brunet     2020-02-13  152  
aa9c3b7273a58b Jerome Brunet     2020-02-13  153  	link->codecs = codec;
aa9c3b7273a58b Jerome Brunet     2020-02-13  154  	link->num_codecs = num_codecs;
aa9c3b7273a58b Jerome Brunet     2020-02-13  155  
6c05494fd8e28e Ai Chao           2025-05-20  156  	for_each_child_of_node_scoped(node, np) {
2e1dbea1f8a358 Kuninori Morimoto 2023-06-20  157  		ret = meson_card_parse_dai(card, np, codec);
6c05494fd8e28e Ai Chao           2025-05-20  158  		if (ret)
aa9c3b7273a58b Jerome Brunet     2020-02-13  159  			return ret;
aa9c3b7273a58b Jerome Brunet     2020-02-13  160  
aa9c3b7273a58b Jerome Brunet     2020-02-13  161  		codec++;
aa9c3b7273a58b Jerome Brunet     2020-02-13  162  	}
aa9c3b7273a58b Jerome Brunet     2020-02-13  163  
aa9c3b7273a58b Jerome Brunet     2020-02-13  164  	ret = meson_card_set_link_name(card, link, node, "be");
aa9c3b7273a58b Jerome Brunet     2020-02-13  165  	if (ret)
aa9c3b7273a58b Jerome Brunet     2020-02-13 @166  		dev_err(card->dev, "error setting %pOFn link name\n", np);
aa9c3b7273a58b Jerome Brunet     2020-02-13  167  
aa9c3b7273a58b Jerome Brunet     2020-02-13  168  	return ret;
aa9c3b7273a58b Jerome Brunet     2020-02-13  169  }
aa9c3b7273a58b Jerome Brunet     2020-02-13  170  EXPORT_SYMBOL_GPL(meson_card_set_be_link);
aa9c3b7273a58b Jerome Brunet     2020-02-13  171  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ