linux-kernel - Re: [PATCH] i2c: mlxbf: avoid 64-bit division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <amrhua2siuph5y3hsxe7domnypcdjfjah5zkmrzcxig5dbmquv@lghx7oo33bo3>
Date: Tue, 20 May 2025 23:57:13 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Khalil Blaiech <kblaiech@...dia.com>, Asmaa Mnebhi <asmaa@...dia.com>, 
	Arnd Bergmann <arnd@...db.de>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: mlxbf: avoid 64-bit division

Hi Arnd,

On Tue, May 20, 2025 at 05:25:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The 64-bit division in mlxbf_i2c_get_ticks() causes link failures
> when compile-testing on 32-bit machines:
> 
> ERROR: modpost: "__udivdi3" [drivers/i2c/busses/i2c-mlxbf.ko] undefined!
> 
> Change this to a div_u64(), which should replace the constant division
> with a a multiply/shift combination in the mlxbf_i2c_get_ticks().
> 
> The frequency calculation functions require a slow library call but
> should be used much rarer.
> 
> Fixes: 9c6c6fa671f9 ("i2c: mlxbf: Allow build with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

merged to i2c/i2c-host.

Thanks,
Andi