linux-kernel - comments on patch "alloc_tag: allocate percpu counters for module tags dynamically"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520231620.15259-1-cachen@purestorage.com>
Date: Tue, 20 May 2025 17:16:20 -0600
From: Casey Chen <cachen@...estorage.com>
To: surenb@...gle.com
Cc: 00107082@....com,
	akpm@...ux-foundation.org,
	cl@...two.org,
	dennis@...nel.org,
	kent.overstreet@...ux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	pasha.tatashin@...een.com,
	tj@...nel.org,
	yzhong@...estorage.com
Subject: comments on patch "alloc_tag: allocate percpu counters for module tags dynamically"

Hi Suren,

I have two questions on this patch.
1. If load_module() fails to allocate memory for percpu counters, should we call codetag_free_module_sections() to clean up module tags memory ?
2. How about moving percpu counters allocation to move_module() where codetag_alloc_module_section() is called ? So they can be cleaned up together.

Thanks,
Casey