linux-kernel - Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e8a404b2-4ec6-4e1d-a973-15684676e870@app.fastmail.com>
Date: Tue, 20 May 2025 08:13:09 +0200
From: "Anisse Astier" <anisse@...ier.eu>
To: "Viresh Kumar" <viresh.kumar@...aro.org>,
 "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
 "Danilo Krummrich" <dakr@...hat.com>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Alex Gaynor" <alex.gaynor@...il.com>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 "Benno Lossin" <benno.lossin@...ton.me>,
 "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, linux-pm@...r.kernel.org,
 "Vincent Guittot" <vincent.guittot@...aro.org>,
 "Stephen Boyd" <sboyd@...nel.org>, "Nishanth Menon" <nm@...com>,
 rust-for-linux@...r.kernel.org,
 "Manos Pitsidianakis" <manos.pitsidianakis@...aro.org>,
 Alex Bennée <alex.bennee@...aro.org>,
 "Joakim Bech" <joakim.bech@...aro.org>, "Rob Herring" <robh@...nel.org>,
 "Yury Norov" <yury.norov@...il.com>, "Burak Emir" <bqe@...gle.com>,
 "Rasmus Villemoes" <linux@...musvillemoes.dk>,
 "Russell King" <linux@...linux.org.uk>, linux-clk@...r.kernel.org,
 "Michael Turquette" <mturquette@...libre.com>,
 "Andrew Ballance" <andrewjballance@...il.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

Mar 20 mai 2025, à 06:33, Viresh Kumar a écrit :
> On 19-05-25, 16:15, Miguel Ojeda wrote:
>> On Mon, May 19, 2025 at 9:08 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>> >
>> > +    /* Rust does not allow hyphens in identifiers, use underscore instead */
>> 
>> (In case you see this before you apply)
>> 
>> Nit: `//` for comments, also please end with a period.
>
> Done.

Thank you Viresh for iterating on this and picking up review comments. Do not hesitate to add your Co-developed-by.

Kind regards,

Anisse