linux-kernel - Re: [PATCH v4 5/6] dt-bindings: iio: adc: adi-axi-adc: add ad7405 example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520-brawny-statuesque-rottweiler-9ae801@kuoka>
Date: Tue, 20 May 2025 08:39:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>, Dragos Bogdan <dragos.bogdan@...log.com>, 
	Antoniu Miclaus <antoniu.miclaus@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>, 
	Javier Carrasco <javier.carrasco.cruz@...il.com>, Matti Vaittinen <mazziesaccount@...il.com>, 
	Tobias Sperling <tobias.sperling@...ting.com>, Alisa-Dariana Roman <alisadariana@...il.com>, 
	Marcelo Schmitt <marcelo.schmitt@...log.com>, 
	João Paulo Gonçalves <joao.goncalves@...adex.com>, Esteban Blanc <eblanc@...libre.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] dt-bindings: iio: adc: adi-axi-adc: add ad7405
 example

On Mon, May 19, 2025 at 05:02:13PM GMT, Pop Ioan Daniel wrote:
> The ad7405 device is defined as a child of the AXI ADC.

1. Why? What we see easily (although not here, because above does not
answer even to what).
2. I do not see any device being added to the binding.

> 
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> ---
> changes in v4:
>  - add ad7405 device that is defined as a child of the AXI ADC
>  .../bindings/iio/adc/adi,axi-adc.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index cf74f84d6103..a6bc8acd101f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -135,4 +135,21 @@ examples:
>              io-backends = <&parallel_bus_controller>;
>          };
>      };
> +  - |
> +    axi_adc@...00000 {

Follow DTS coding style.

> +        compatible = "adi,axi-adc-10.0.a";
> +        reg = <0x44a00000 0x10000>;
> +        dmas = <&rx_dma 0>;
> +        dma-names = "rx";
> +        clocks = <&axi_clk>;
> +        #io-backend-cells = <0>;

This example is already there, so I do not get why you duplicate it.
Skip the patch or with reason add the child to the existing example.

> +
> +        adc@0 {
> +            compatible = "adi,ad7405";

Best regards,
Krzysztof