linux-kernel - Re: [PATCH] MIPS: bcm63xx: nvram: avoid inefficient use of crc32_le

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCwni0qo_2IxfffY@alpha.franken.de>
Date: Tue, 20 May 2025 08:56:11 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH] MIPS: bcm63xx: nvram: avoid inefficient use of
 crc32_le_combine()

On Sun, May 11, 2025 at 11:28:36AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> bcm963xx_nvram_checksum() was using crc32_le_combine() to update a CRC
> with four zero bytes.  However, this is about 5x slower than just
> CRC'ing four zero bytes in the normal way.  Just do that instead.
> 
> (We could instead make crc32_le_combine() faster on short lengths.  But
> all its callers do just fine without it, so I'd like to just remove it.)
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> Please consider this patch for the mips tree for 6.16.  If it doesn't
> get picked up, I'll take it through the crc tree.
> 
>  include/linux/bcm963xx_nvram.h | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)

applied to mips-next

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]