linux-kernel - Re: [PATCH v4 4/5] watchdog: qcom: add support to get the bootstatus from IMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520-delightful-aquatic-woodpecker-d854f6@kuoka>
Date: Tue, 20 May 2025 09:28:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, 
	Rajendra Nayak <quic_rjendra@...cinc.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v4 4/5] watchdog: qcom: add support to get the bootstatus
 from IMEM

On Mon, May 19, 2025 at 02:04:04PM GMT, Kathiravan Thirumoorthy wrote:
> +static int qcom_wdt_get_bootstatus(struct device *dev, struct qcom_wdt *wdt)
> +{
> +	unsigned int args[2];
> +	struct regmap *imem;
> +	unsigned int val;
> +	int ret;
> +
> +	imem = syscon_regmap_lookup_by_phandle_args(dev->of_node, "qcom,imem",
> +						    ARRAY_SIZE(args), args);
> +	if (IS_ERR(imem)) {
> +		ret = PTR_ERR(imem);
> +		if (ret != -ENOENT) {
> +			dev_err(dev, "failed to lookup syscon: %d\n", ret);

Syntax is: return dev_err_probe().

> +			return ret;

Best regards,
Krzysztof