linux-kernel - Re: [PATCH] watchdog: arm_smc_wdt: get wdt status through SMCWD_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf096db75e9a321ee86eeb1685f4f1f5cb140e4b.camel@foss.st.com>
Date: Tue, 20 May 2025 10:49:46 +0200
From: Antonio Borneo <antonio.borneo@...s.st.com>
To: Guenter Roeck <linux@...ck-us.net>, Julius Werner <jwerner@...omium.org>
CC: Evan Benn <evanbenn@...omium.org>,
        Wim Van Sebroeck
	<wim@...ux-watchdog.org>,
        <linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] watchdog: arm_smc_wdt: get wdt status through
 SMCWD_GET_TIMELEFT

On Mon, 2025-05-19 at 18:13 -0700, Guenter Roeck wrote:
> On 5/19/25 17:12, Julius Werner wrote:
> > I don't really know about the issue Guenter mentioned, but otherwise,
> > from the driver's side this looks good to me.
> > 
> 
> It should just be
>         set_bit(WDOG_HW_RUNNING, &wdd->status);
> 
> There should be no dependency on CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED.
> 
> Guenter
> 

Thanks for the review!
I agree on Guenter's comment and I will send a V2 shortly.

Regards
Antonio