linux-kernel - Re: [PATCH] drm/panel-simple: fix the warnings for the Evervision VGG644804

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35cf95f6-30ba-4833-a059-e455d7370fda@linaro.org>
Date: Tue, 20 May 2025 10:56:38 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Michael Walle <mwalle@...nel.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel-simple: fix the warnings for the Evervision
 VGG644804

On 20/05/2025 09:41, Michael Walle wrote:
> The panel lacked the connector type which causes a warning. Adding the
> connector type reveals wrong bus_flags and bits per pixel. Fix all of
> it.
> 
> Fixes: 1319f2178bdf ("drm/panel-simple: add Evervision VGG644804 panel entry")
> Signed-off-by: Michael Walle <mwalle@...nel.org>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 82ee2f12b8d2..0a3b26bb4d73 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2198,13 +2198,14 @@ static const struct display_timing evervision_vgg644804_timing = {
>   static const struct panel_desc evervision_vgg644804 = {
>   	.timings = &evervision_vgg644804_timing,
>   	.num_timings = 1,
> -	.bpc = 8,
> +	.bpc = 6,
>   	.size = {
>   		.width = 115,
>   		.height = 86,
>   	},
>   	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   
>   static const struct display_timing evervision_vgg804821_timing = {

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>