linux-kernel - Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCvgbd5dZrF0YJg7@google.com>
Date: Mon, 19 May 2025 18:52:45 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Leo Yan <leo.yan@....com>, Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison

Hi Leo,

On Fri, May 16, 2025 at 04:31:58PM +0100, Leo Yan wrote:
> Hi Ian, Namhyung,
> 
> [ - Mailing list ]
> 
> On Wed, Apr 02, 2025 at 10:05:16AM +0100, Leo Yan wrote:
> > On Tue, Apr 01, 2025 at 12:54:12PM -0700, Ian Rogers wrote:
> > > On Tue, Apr 1, 2025 at 2:14 AM Leo Yan <leo.yan@....com> wrote:
> > > >
> > > > On Mon, Mar 31, 2025 at 01:18:31PM -0700, Ian Rogers wrote:
> > > >
> > > > [...]
> > > >
> > > > > I'm reminded of a Java check I wrote for this:
> > > >
> > > > Nice short article.
> > > >
> > > > > In clang -Wshorten-64-to-32 looks to cover this. I'll see if we can
> > > > > clean those warnings up a bit.
> > > >
> > > > I checked a bit and seems GCC has no this flag, but it makes sense for
> > > > me to enable the flag for Clang.
> > > >
> > > > > Reviewed-by: Ian Rogers <irogers@...gle.com>
> > > >
> > > > Thanks a lot, Ian.
> > > 
> > > I made a small variation to the change in:
> > > https://lore.kernel.org/lkml/20250401182347.3422199-10-irogers@google.com/
> > > to avoid a subtract and just directly compare the values.
> 
> Do you mind to pick up my this patch? :) Our internal CI reports the
> test case 109_Track_with_sched_switch failure daily, I am just wandering
> if we could apply the fix quickly.

Arnaldo is taking care of patches for v6.15.

Arnaldo, can you please take this?

Thanks,
Namhyung

> 
> Ian is working on a patch series for resolving the Clang warning which
> also includes a fix [1], if Ian could extract the fix for the compar()
> function in switch-tracking.c, this either would be fine for me.
> 
> Thanks a lot for your helping!
> 
> Leo
> 
> [1] https://lore.kernel.org/linux-perf-users/20250401182347.3422199-10-irogers@google.com/