linux-kernel - Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCxIlnPsVZBiUpc8@hovoldconsulting.com>
Date: Tue, 20 May 2025 11:17:10 +0200
From: Johan Hovold <johan@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with
 version

On Tue, May 20, 2025 at 10:51:56AM +0200, Krzysztof Kozlowski wrote:
> On 20/05/2025 10:44, Bryan O'Donoghue wrote:

> > I find the debug prints useful in that I know the hardware block has 
> > been powered on, clocked etc. I agree the number of those prints seems 
> > excessive.
> > 
> > The reason it is printed out multiple time is the blocks get powered on/off.
> > 
> > Personally I agree with Johan - it would be nice/useful to print it out 
> > once with DEBUG on, so that we know we have successfully powered-on and 
> 
> That's opposite to what coding style asks. Success should be silent.

The coding style says probe should be silent, but debug statements are
not printed by default so that bit does not apply here.

Johan