linux-kernel - Re: [PATCH] Documentation: kunit: improve example on testing static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62602f2b-1f87-4510-a27b-cd0755cdfae2@t-8ch.de>
Date: Tue, 20 May 2025 11:55:12 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Rae Moar <rmoar@...gle.com>, skhan@...uxfoundation.org
Cc: davidgow@...gle.com, brendan.higgins@...ux.dev, rdlatypov@...gle.com, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] Documentation: kunit: improve example on testing static
 functions

On 2025-05-16 19:06:31+0000, Rae Moar wrote:

<snip>

> -Alternatively, you could conditionally ``#include`` the test file at the end of
> -your .c file. For example:
> +	/* In the KUnit test file "my_file_test.c" */
> +
> +	#include <kunit/visibility.h>
> +	#include <my_file.h>
> +	...
> +	MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);

This should to be MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING").
See commit cdd30ebb1b9f ("module: Convert symbol namespace to string literal")

Can this still be fixed up?

> +	...
> +	// Use do_interesting_thing() in tests

<snip>