linux-kernel - Re: [PATCH v3] platform/x86/intel/pmc Fix Arrow Lake U/H support to intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef7c13efe46aff5d23e2b4196b6dee608eb2603c.camel@intel.com>
Date: Tue, 20 May 2025 11:04:33 +0000
From: "Brandt, Todd E" <todd.e.brandt@...el.com>
To: "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>
CC: "xi.pardee@...ux.intel.com" <xi.pardee@...ux.intel.com>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] platform/x86/intel/pmc Fix Arrow Lake U/H support to
 intel_pmc_core driver

On Tue, 2025-05-20 at 13:54 +0300, Ilpo Järvinen wrote:
> On Tue, 20 May 2025, Todd Brandt wrote:
> 
> > The ARL requires that the GMA and NPU devices both be in D3Hot in
> > order
> > for PC10 and S0iX to be achieved in S2idle. The original ARL-H/U
> > addition
> > to the intel_pmc_core driver attempted to do this by switching them
> > to D3
> > in the init and resume calls of the intel_pmc_core driver.
> > 
> > The problem is the ARL-H/U have a different NPU device and thus are
> > not
> > being properly set and thus S0iX does not work properly in ARL-H/U.
> > This
> > patch creates a new ARL-H specific device id that is correct and
> > also
> > adds the D3 fixup to the suspend callback. This way if the PCI
> > devies
> > drop from D3 to D0 after resume they can be corrected for the next
> > suspend. Thus there is no dropout in S0iX.
> > 
> > [v2 changes]
> > 
> > Added Fixes line
> > 
> > [v3 changes]
> > 
> > Xi asked that I see if adding the arl_h_suspend call actually made
> > any
> > difference in fixing the issue of S0iX not being achieved, as there
> > are
> > 4 other platforms that use this same fix in just the init and
> > resume
> > callbacks. Upon further testing I discovered it didn't matter. So I
> > just
> > simplified the D3 change and left the fixup call to init and
> > resume.
> 
> Okay, I've replaced the commit in the review-ilpo-fixes branch with
> this 
> v3 patch. Thanks.
> 
> In future, put that patch vX history under --- line so I don't have
> to 
> manually remove it (our tools cut the text below that triple dash
> line
> automatically).
> 

Will do, sorry about that.