linux-kernel - Re: [PATCH] i2c: qup: Add error handling in qup_i2c_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mibpejiq6cu7ehhitvksmdwdnmx76dce24ngybccpvlb5x6v7q@wgdlvcmg7uxa>
Date: Tue, 20 May 2025 13:51:36 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
Cc: Wentao Liang <vulab@...as.ac.cn>, linux-arm-msm@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] i2c: qup: Add error handling in qup_i2c_xfer_v2()

Hi Mukesh,

...

> > @@ -1588,7 +1588,9 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >   		ret = qup_i2c_bus_active(qup, ONE_BYTE);
> >   	if (!ret)
> > -		qup_i2c_change_state(qup, QUP_RESET_STATE);
> > +		err = qup_i2c_change_state(qup, QUP_RESET_STATE);
> > +	if (err)
> > +		return err;
> Is there an error seen around this ? Expecting this to work as is.
> After an error, what next ? Just return back to framework ?

thanks for chiming in. qup_i2c_change_state() can fail, why
shouldn't we consider the possibility to fail?

Thanks,
Andi