| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250520123544.4087208-1-senozhatsky@chromium.org> Date: Tue, 20 May 2025 21:35:12 +0900 From: Sergey Senozhatsky <senozhatsky@...omium.org> To: Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>, Matthew Bobrowski <repnop@...gle.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, Sergey Senozhatsky <senozhatsky@...omium.org> Subject: [RFC PATCH] fanotify: wake-up all waiters on release Once reply response is set for all outstanding requests wake_up_all() of the ->access_waitq waiters so that they can finish user-wait. Otherwise fsnotify_destroy_group() can wait forever for ->user_waits to reach 0 (which it never will.) Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org> --- fs/notify/fanotify/fanotify_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index 87f861e9004f..95a3b843cbbf 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c @@ -1046,8 +1046,8 @@ static int fanotify_release(struct inode *ignored, struct file *file) } spin_unlock(&group->notification_lock); - /* Response for all permission events it set, wakeup waiters */ - wake_up(&group->fanotify_data.access_waitq); + /* Response for all permission events is set, wakeup waiters */ + wake_up_all(&group->fanotify_data.access_waitq); /* matches the fanotify_init->fsnotify_alloc_group */ fsnotify_destroy_group(group); -- 2.49.0.1101.gccaa498523-goog
Powered by blists - more mailing lists