linux-kernel - Re: [PATCH] drm/sitronix: Fix broken backwards-compatibility layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07088966-73f4-4b5d-898d-b596dede53e4@suse.de>
Date: Tue, 20 May 2025 15:04:36 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Marcus Folkesson <marcus.folkesson@...il.com>,
 Javier Martinez Canillas <javierm@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/sitronix: Fix broken backwards-compatibility layer

Hi

Am 20.05.25 um 14:40 schrieb Geert Uytterhoeven:
> When moving the Sitronix DRM drivers and renaming their Kconfig symbols,
> the old symbols were kept, aiming to provide a seamless migration path
> when running "make olddefconfig" or "make oldconfig".
>
> However, the old compatibility symbols are not visible.  Hence unless
> they are selected by another symbol (which they are not), they can never
> be enabled, and no backwards compatibility is provided.
>
> Fix this by making them visible, and inverting the selection logic.
> Add comments to make it clear why there are two symbols with the same
> description.

These symbols were only meant for variants of 'make oldconfig' to pick 
up th enew symbols. They where never for being selected manually.

Best regards
Thomas

>
> Fixes: 9b8f32002cddf792 ("drm/sitronix: move tiny Sitronix drivers to their own subdir")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> arch/arm/configs/davinci_all_defconfig must be updated after this has
> hit upstream.
> ---
>   drivers/gpu/drm/sitronix/Kconfig | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/sitronix/Kconfig b/drivers/gpu/drm/sitronix/Kconfig
> index c069d0d417753bcf..8b3565b8eca3918e 100644
> --- a/drivers/gpu/drm/sitronix/Kconfig
> +++ b/drivers/gpu/drm/sitronix/Kconfig
> @@ -10,9 +10,11 @@ config DRM_ST7571_I2C
>   
>   	  if M is selected the module will be called st7571-i2c.
>   
> +# To be removed once all users have updated their (def)configs
>   config TINYDRM_ST7586
> -	tristate
> -	default n
> +	tristate "DRM support for Sitronix ST7586 display panels"
> +	depends on DRM && SPI
> +	select DRM_ST7586
>   
>   config DRM_ST7586
>   	tristate "DRM support for Sitronix ST7586 display panels"
> @@ -21,16 +23,17 @@ config DRM_ST7586
>   	select DRM_KMS_HELPER
>   	select DRM_GEM_DMA_HELPER
>   	select DRM_MIPI_DBI
> -	default TINYDRM_ST7586
>   	help
>   	  DRM driver for the following Sitronix ST7586 panels:
>   	  * LEGO MINDSTORMS EV3
>   
>   	  If M is selected the module will be called st7586.
>   
> +# To be removed once all users have updated their (def)configs
>   config TINYDRM_ST7735R
> -	tristate
> -	default n
> +	tristate "DRM support for Sitronix ST7715R/ST7735R display panels"
> +	depends on DRM && SPI
> +	select DRM_ST7735R
>   
>   config DRM_ST7735R
>   	tristate "DRM support for Sitronix ST7715R/ST7735R display panels"
> @@ -40,7 +43,6 @@ config DRM_ST7735R
>   	select DRM_GEM_DMA_HELPER
>   	select DRM_MIPI_DBI
>   	select BACKLIGHT_CLASS_DEVICE
> -	default TINYDRM_ST7735R
>   	help
>   	  DRM driver for Sitronix ST7715R/ST7735R with one of the following
>   	  LCDs:

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)