linux-kernel - Re: [PATCH v2] checkpatch: use utf-8 match for spell checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1bd523b-e7da-41eb-ad1a-a56488c4f0cd@foss.st.com>
Date: Tue, 20 May 2025 15:14:02 +0200
From: Clement LE GOFFIC <clement.legoffic@...s.st.com>
To: Antonio Borneo <antonio.borneo@...s.st.com>,
        Andy Whitcroft
	<apw@...onical.com>, Joe Perches <joe@...ches.com>,
        Dwaipayan Ray
	<dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
CC: <linux-kernel@...r.kernel.org>,
        Clément Léger
	<clement.leger@...tlin.com>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH v2] checkpatch: use utf-8 match for spell checking

On 5/6/24 14:07, Clement LE GOFFIC wrote:
> Hello,
> 
> A gentle reminder to review this patch.
> 
> Best regards,
> 
> Clément
> 
> On 1/2/24 17:10, Antonio Borneo wrote:
>> The current code that checks for misspelling verifies, in a more
>> complex regex, if $rawline matches [^\w]($misspellings)[^\w]
>>
>> Being $rawline a byte-string, a utf-8 character in $rawline can
>> match the non-word-char [^\w].
>> E.g.:
>>     ./scripts/checkpatch.pl --git 81c2f059ab9
>>     WARNING: 'ment' may be misspelled - perhaps 'meant'?
>>     #36: FILE: MAINTAINERS:14360:
>>     +M:     Clément Léger <clement.leger@...tlin.com>
>>                 ^^^^
>>
>> Use a utf-8 version of $rawline for spell checking.
>>
>> Signed-off-by: Antonio Borneo <antonio.borneo@...s.st.com>
>> Reported-by: Clément Le Goffic <clement.legoffic@...s.st.com>
>> ---
>> Changes in v2:
>> - use $rawline_utf8 also in the while-loop's body;
>> - fix path of checkpatch in the commit message.
>> ---
>>   scripts/checkpatch.pl | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 25fdb7fda112..2d122d232c6d 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3477,9 +3477,10 @@ sub process {
>>   # Check for various typo / spelling mistakes
>>           if (defined($misspellings) &&
>>               ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>> -            while ($rawline =~ /(?:^|[^\w\-'`])($misspellings)(?: 
>> [^\w\-'`]|$)/gi) {
>> +            my $rawline_utf8 = decode("utf8", $rawline);
>> +            while ($rawline_utf8 =~ /(?:^|[^\w\-'`])($misspellings) 
>> (?:[^\w\-'`]|$)/gi) {
>>                   my $typo = $1;
>> -                my $blank = copy_spacing($rawline);
>> +                my $blank = copy_spacing($rawline_utf8);
>>                   my $ptr = substr($blank, 0, $-[1]) . "^" x 
>> length($typo);
>>                   my $hereptr = "$hereline$ptr\n";
>>                   my $typo_fix = $spelling_fix{lc($typo)};
>>
>> base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86

Hi,

Is it just due to -ENOTIME for the maintainers, or are there doubts 
about this patch? (inspired from a response of Uwe).

Clément