linux-kernel - Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <125293c8-c5a6-4fa8-bf5c-4da8d2fbf510@ti.com>
Date: Mon, 19 May 2025 21:28:45 -0500
From: Andrew Davis <afd@...com>
To: Mark Brown <broonie@...nel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ

On 5/19/25 5:12 AM, Mark Brown wrote:
> On Fri, May 16, 2025 at 09:17:22AM -0500, Andrew Davis wrote:
>> If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
>> This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
>> based on the above two symbols respectively. This makes it very easy
>> to end up with "circular dependencies".
>>
>> Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
>> use of them. This is almost equivalent to before but makes it less
>> likely to end up with false circular dependency detections.
> 
> None of these selects should actually do anything since the symbols are
> themselves selected?

I was thinking the same, but turns out (and I had to check to prove it to
myself) that "select" actually follows up the dependency tree. So unlike
"depends on" which is weird(broken), "select" functions in a sane way.

Andrew