linux-kernel - Re: [PATCH] efi/efi_test: Fix missing pending status update in getwakeuptime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGzn4sbb3DZWLsfUT9DePW0M1AUTduo9g06d75D=tiJ-A@mail.gmail.com>
Date: Wed, 21 May 2025 15:40:24 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Ivan Hu <ivan.hu@...onical.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi/efi_test: Fix missing pending status update in getwakeuptime

On Mon, 31 Mar 2025 at 09:45, Ivan Hu <ivan.hu@...onical.com> wrote:
>
> The pending status was not being passed to user space, leading to
> false test alarms when using the pending status. This patch ensures
> that the pending status is correctly updated and exposed to user space
> when calling getwakeuptime, preventing incorrect handling of the pending
> status.
>
> Signed-off-by: Ivan Hu <ivan.hu@...onical.com>
> ---
>  drivers/firmware/efi/test/efi_test.c | 4 ++++
>  1 file changed, 4 insertions(+)
>

Queued up now, thanks.

> diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
> index 9e2628728aad..77b5f7ac3e20 100644
> --- a/drivers/firmware/efi/test/efi_test.c
> +++ b/drivers/firmware/efi/test/efi_test.c
> @@ -361,6 +361,10 @@ static long efi_runtime_get_waketime(unsigned long arg)
>                                                 getwakeuptime.enabled))
>                 return -EFAULT;
>
> +       if (getwakeuptime.pending && put_user(pending,
> +                                               getwakeuptime.pending))
> +               return -EFAULT;
> +
>         if (getwakeuptime.time) {
>                 if (copy_to_user(getwakeuptime.time, &efi_time,
>                                 sizeof(efi_time_t)))
> --
> 2.34.1
>