linux-kernel - Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <61db74cd-2d6c-4880-8e80-12baa338a727@app.fastmail.com>
Date: Wed, 21 May 2025 16:10:47 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Alexander Potapenko" <glider@...gle.com>,
 "Linux Memory Management List" <linux-mm@...ck.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>
Cc: "Nathan Chancellor" <nathan@...nel.org>,
 "Lukas Bulwahn" <lbulwahn@...hat.com>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Nicolas Schier" <nicolas.schier@...ux.dev>,
 "Andrey Konovalov" <andreyknvl@...il.com>, linux-kbuild@...r.kernel.org,
 kasan-dev@...glegroups.com, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Lukas Bulwahn" <lukas.bulwahn@...hat.com>,
 "Dmitry Vyukov" <dvyukov@...gle.com>
Subject: Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in
 CFLAGS_KCOV

On Wed, May 21, 2025, at 12:02, Alexander Potapenko wrote:
> On Tue, May 20, 2025 at 4:57 PM 'Dmitry Vyukov' via kasan-dev
> <kasan-dev@...glegroups.com> wrote:
>>
>> On Thu, 8 May 2025 at 18:44, Nathan Chancellor <nathan@...nel.org> wrote:
>> >
>> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote:
>> > > From: Lukas Bulwahn <lukas.bulwahn@...hat.com>
>> > >
>> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes the
>> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the
>> > > compiler option '-fsanitize-coverage=trace-pc' by now.
>> > >
>> > > The commit however misses the important use of this config option in
>> > > Makefile.kcov to add '-fsanitize-coverage=trace-pc' to CFLAGS_KCOV.
>> > > Include the compiler option '-fsanitize-coverage=trace-pc' unconditionally
>> > > to CFLAGS_KCOV, as all compilers provide that option now.
>> > >
>> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin")
>> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...hat.com>
>> >
>> > Good catch.
>> >
>> > Reviewed-by: Nathan Chancellor <nathan@...nel.org>
>>
>> Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>
>>
>> Thanks for fixing this!
>
> @akpm, could you please take this patch at your convenience?

I have applied it on the asm-generic tree now, as this contains
the original broken commit. Sorry for missing it earlier.

      Arnd