linux-kernel - Re: [PATCH v3 7/7] perf python: Add counting.py as example for counting perf events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC3nY4jVQ9ufeXqn@x1>
Date: Wed, 21 May 2025 11:46:59 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Gautam Menghani <gautam@...ux.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Howard Chu <howardchu95@...il.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, maddy@...ux.ibm.com
Subject: Re: [PATCH v3 7/7] perf python: Add counting.py as example for
 counting perf events

On Mon, May 19, 2025 at 12:51:44PM -0700, Ian Rogers wrote:
> From: Gautam Menghani <gautam@...ux.ibm.com>
> 
> Add counting.py - a python version of counting.c to demonstrate
> measuring and reading of counts for given perf events.
> 
> Signed-off-by: Gautam Menghani <gautam@...ux.ibm.com>
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Tested and applied:

Committer testing:

Build perf and make the generated python binding somewhere you can point
to to avoid using the one in the distro python3-perf (fedora, may be
different in other distros):

  $ make -k O=/tmp/build/$(basename $PWD)/ -C tools/perf install-bin

Copy /tmp/build/perf-tools-next/python/perf.cpython-313-x86_64-linux-gnu.so to
somewhere outside this toolbox container and then use it with root:

  # export PYTHONPATH=/root/python/
  # ls -la /root/python/
  total 10640
  drwxr-xr-x. 1 root root       72 May 21 11:40 .
  dr-xr-x---. 1 root root      574 May 21 11:40 ..
  -rwxr-xr-x. 1 acme acme 10894360 May 21 11:40 perf.cpython-313-x86_64-linux-gnu.so
  # tools/perf/python/counting.py | head -5
  For evsel(software/cpu-clock/) val: 2930946 enable: 2932479 run: 2932479
  For evsel(software/cpu-clock/) val: 2924975 enable: 2926267 run: 2926267
  For evsel(software/cpu-clock/) val: 2921017 enable: 2922430 run: 2922430
  For evsel(software/cpu-clock/) val: 2914966 enable: 2916549 run: 2916549
  For evsel(software/cpu-clock/) val: 2910027 enable: 2911589 run: 2911589
  #

It would be nice to have something that compares the output for some
envent obtained from both 'perf stat' and using these new python
counting classes, but that can be done later.

Applied to perf-tools-next,

- Arnaldo

> ---
> Ian modified from v2 to make the API take a CPU and thread then
> compute from these the appropriate indices. This was discussed as the
> preferred API with Arnaldo:
> https://lore.kernel.org/linux-perf-users/20250512055748.479786-1-gautam@linux.ibm.com/
> The use of a thread_map and cpu_map was also removed to make the code
> cleaner, instead the cpus and threads of the parsed evsel are
> used. Support for command line events is also added. The indent is
> reduced from 8 to 4 to match the preferred python PEP8 indent.
> ---
>  tools/perf/python/counting.py | 36 +++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100755 tools/perf/python/counting.py
> 
> diff --git a/tools/perf/python/counting.py b/tools/perf/python/counting.py
> new file mode 100755
> index 000000000000..02121d2bb11d
> --- /dev/null
> +++ b/tools/perf/python/counting.py
> @@ -0,0 +1,36 @@
> +#!/usr/bin/env python3
> +# SPDX-License-Identifier: GPL-2.0
> +# -*- python -*-
> +# -*- coding: utf-8 -*-
> +
> +import argparse
> +import perf
> +
> +def main(event: str):
> +    evlist = perf.parse_events(event)
> +
> +    for evsel in evlist:
> +        evsel.read_format = perf.FORMAT_TOTAL_TIME_ENABLED | perf.FORMAT_TOTAL_TIME_RUNNING
> +
> +    evlist.open()
> +    evlist.enable()
> +
> +    count = 100000
> +    while count > 0:
> +        count -= 1
> +
> +    evlist.disable()
> +
> +    for evsel in evlist:
> +        for cpu in evsel.cpus():
> +            for thread in evsel.threads():
> +                counts = evsel.read(cpu, thread)
> +                print(f"For {evsel} val: {counts.val} enable: {counts.ena} run: {counts.run}")
> +
> +    evlist.close()
> +
> +if __name__ == '__main__':
> +    ap = argparse.ArgumentParser()
> +    ap.add_argument('-e', '--event', help="Events to open", default="cpu-clock,task-clock")
> +    args = ap.parse_args()
> +    main(args.event)
> -- 
> 2.49.0.1101.gccaa498523-goog
>