linux-kernel - Re: [PATCH v2] security,fs,nfs,net: update security_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4842839-20e9-4ff3-8551-3e33d1c87e44@schaufler-ca.com>
Date: Tue, 20 May 2025 17:22:38 -0700
From: Casey Schaufler <casey@...aufler-ca.com>
To: Paul Moore <paul@...l-moore.com>, Trond Myklebust <trondmy@...nel.org>,
 Anna Schumaker <anna@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Cc: Stephen Smalley <stephen.smalley.work@...il.com>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>,
 Eric Dumazet <edumazet@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>,
 Paolo Abeni <pabeni@...hat.com>, Willem de Bruijn <willemb@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Simon Horman <horms@...nel.org>,
 Ondrej Mosnacek <omosnace@...hat.com>, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-security-module@...r.kernel.org, netdev@...r.kernel.org,
 selinux@...r.kernel.org, Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH v2] security,fs,nfs,net: update
 security_inode_listsecurity() interface

On 5/20/2025 2:31 PM, Paul Moore wrote:
> On Tue, Apr 29, 2025 at 7:34 PM Paul Moore <paul@...l-moore.com> wrote:
>> On Mon, Apr 28, 2025 at 4:15 PM Stephen Smalley
>> <stephen.smalley.work@...il.com> wrote:
>>> Update the security_inode_listsecurity() interface to allow
>>> use of the xattr_list_one() helper and update the hook
>>> implementations.
>>>
>>> Link: https://lore.kernel.org/selinux/20250424152822.2719-1-stephen.smalley.work@gmail.com/
>>>
>>> Signed-off-by: Stephen Smalley <stephen.smalley.work@...il.com>

Acked-by: Casey Schaufler <casey@...aufler-ca.com>

I haven't been able to test the change in Smack, but it appears reasonable.

>>> ---
>>> This patch is relative to the one linked above, which in theory is on
>>> vfs.fixes but doesn't appear to have been pushed when I looked.
>>>
>>>  fs/nfs/nfs4proc.c             | 10 ++++++----
>>>  fs/xattr.c                    | 19 +++++++------------
>>>  include/linux/lsm_hook_defs.h |  4 ++--
>>>  include/linux/security.h      |  5 +++--
>>>  net/socket.c                  | 17 +++++++----------
>>>  security/security.c           | 16 ++++++++--------
>>>  security/selinux/hooks.c      | 10 +++-------
>>>  security/smack/smack_lsm.c    | 13 ++++---------
>>>  8 files changed, 40 insertions(+), 54 deletions(-)
>> Thanks Stephen.  Once we get ACKs from the NFS, netdev, and Smack
>> folks I can pull this into the LSM tree.
> Gentle ping for Trond, Anna, Jakub, and Casey ... can I get some ACKs
> on this patch?  It's a little late for the upcoming merge window, but
> I'd like to merge this via the LSM tree after the merge window closes.
>
> Link to the patch if you can't find it in your inbox:
> https://lore.kernel.org/linux-security-module/20250428195022.24587-2-stephen.smalley.work@gmail.com/
>
> --
> paul-moore.com
>