linux-kernel - Re: [PATCH 2/4] docs: Improve grammar, formatting in Video4Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6954169-63d9-4cac-aabd-2df1642f98af@gmail.com>
Date: Wed, 21 May 2025 18:17:37 +0300
From: Hanne-Lotta Mäenpää <hannelotta@...il.com>
To: Bagas Sanjaya <bagasdotme@...il.com>, Jonathan Corbet <corbet@....net>,
 mchehab@...nel.org, ribalda@...omium.org, hverkuil@...all.nl,
 hljunggr@...co.com, dave.jiang@...el.com, jgg@...pe.ca, saeedm@...dia.com,
 Jonathan.Cameron@...wei.com, ilpo.jarvinen@...ux.intel.com,
 mario.limonciello@....com, W_Armin@....de, mpearson-lenovo@...ebb.ca
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 2/4] docs: Improve grammar, formatting in Video4Linux

Hello,

On 5/19/25 04:23, Bagas Sanjaya wrote:
> On Sun, May 18, 2025 at 02:08:04AM -0600, Jonathan Corbet wrote:
>>>       description of the correct character encoding for Programme Service
>>>       name strings. Also from RDS specification, PS is usually a single
>>>       eight character text. However, it is also possible to find receivers
>>> -    which can scroll strings sized as 8 x N characters. So, this control
>>> +    which can scroll strings sized as 8 x N characters. Therefore this control
>>
>> This kind of change just seems like churn that isn't really improving
>> the content?
> 
> I prefer the original as both so and therefore have the same meaning.>
>>>   ``V4L2_CID_RDS_TX_ALT_FREQS (__u32 array)``
>>>       The alternate frequencies in kHz units. The RDS standard allows for
>>> -    up to 25 frequencies to be defined. Drivers may support fewer
>>> -    frequencies so check the array size.
>>> +    up to 25 frequencies to be defined. Because drivers may support fewer
>>> +    frequencies, check the array size.
>>
>> Here too, I'm not sure I see the value in this kind of change.
> 
> Again I'm agree.
> 
> Thanks.
> 

Alright, that is two opinions in favor of not changing this. I can send 
a version 2 of this patch series without these.

Thank you for reviewing!

Best regards,

Hanne-Lotta Mäenpää