linux-kernel - Re: [PATCH] rust: list: Use "List::is_empty()" to perform checking when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250521152307.1055810-1-ojeda@kernel.org>
Date: Wed, 21 May 2025 17:23:07 +0200
From: Miguel Ojeda <ojeda@...nel.org>
To: richard120310@...il.com,
	aliceryhl@...gle.com
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	gary@...yguo.net,
	jserv@...s.ncku.edu.tw,
	linux-kernel-mentees@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	ojeda@...nel.org,
	rust-for-linux@...r.kernel.org,
	skhan@...uxfoundation.org,
	tmgross@...ch.edu
Subject: Re: [PATCH] rust: list: Use "List::is_empty()" to perform checking when possible

On Mon, 10 Mar 2025 15:38:52 +0800 I Hsin Cheng <richard120310@...il.com> wrote:
>
> "List::is_empty()" provides a straight forward convention to check
> whether a given "List" is empty or not. There're numerous places in the
> current implementation still use "self.first.is_null()" to perform the
> equivalent check, replace them with "List::is_empty()".
>
> Signed-off-by: I Hsin Cheng <richard120310@...il.com>

There are a couple cases that still apply here (i.e. after the cursor
between elements change), so I will pick it up.

By the way, for some reason, your email did not reach my inbox.

Thanks!

Cheers,
Miguel