linux-kernel - Re: [PATCH v5 02/20] cpu: Define attack vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250521152834.GEaC3xIlODfZuSsXav@fat_crate.local>
Date: Wed, 21 May 2025 17:28:34 +0200
From: Borislav Petkov <bp@...en8.de>
To: David Kaplan <david.kaplan@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 02/20] cpu: Define attack vectors

On Fri, May 09, 2025 at 11:28:21AM -0500, David Kaplan wrote:
> +#define smt_mitigations SMT_MITIGATIONS_OFF

Oh fun.

Let's make that explicit before someone goes and shuffles the enums:

diff --git a/include/linux/cpu.h b/include/linux/cpu.h
index 4da2ee8d9144..fdf552fd8a8b 100644
--- a/include/linux/cpu.h
+++ b/include/linux/cpu.h
@@ -203,7 +203,7 @@ enum cpu_attack_vectors {
 };
 
 enum smt_mitigations {
-	SMT_MITIGATIONS_OFF,
+	SMT_MITIGATIONS_OFF = 0,
 	SMT_MITIGATIONS_AUTO,
 	SMT_MITIGATIONS_ON,
 };

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette