linux-kernel - Re: [V1 2/2] drivers soc: add support for ST stm32mp13xx family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf69b49a-e2bf-44a9-ad7b-df01572457b0@enneenne.com>
Date: Wed, 21 May 2025 17:44:18 +0200
From: Rodolfo Giometti <giometti@...eenne.com>
To: Yann Gautier <yann.gautier@...s.st.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Eric Fourmont <eric.fourmont-ext@...com>, linux-kernel@...r.kernel.org
Subject: Re: [V1 2/2] drivers soc: add support for ST stm32mp13xx family

On 20/05/25 18:58, Yann Gautier wrote:
> On 5/19/25 15:08, Rodolfo Giometti wrote:

[snip]

>> +static int __init stm32mp13_soc_get_rpn_uid(u32 *rpn, u32 uid[3])
>> +{
>> +    struct device_node *np;
>> +    void __iomem *regs;
>> +    static const struct of_device_id devids[] = {
>> +        { .compatible = "st,stm32mp13-bsec" },
>> +        { },
>> +    };
> 
> As said by Krzysztof, you cannot access the OTP fuses this way.
> There is already a driver for that: drivers/nvmem/stm32-romem.c.
> And the information there should be accessed through nvmem framework.
> 
> For the UID, you should add this in your first patch:
>              uid_otp: uid-otp@34 {
>                  reg = <0x34 0xc>;
>              };
> 
> And add &part_number_otp and &uid_otp to your driver nvmem-cells property:
> nvmem-cells = <&cfg0_otp>, <&part_number_otp>, <&uid_otp>;

I see, but since the device is called by the device_initcall(), when I try to 
use the nvmem framework I always get the EPROBE_DEFER error. :(

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming