linux-kernel - 回复: [EXT] Re: [PATCH] input: goodix: add poll mode for goodix touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB8PR04MB6939C50490CA40E037A8857C949EA@DB8PR04MB6939.eurprd04.prod.outlook.com>
Date: Wed, 21 May 2025 02:53:06 +0000
From: Joseph Guo <qijian.guo@....com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
CC: Bastien Nocera <hadess@...ess.net>, Hans de Goede <hdegoede@...hat.com>,
	"open list:GOODIX TOUCHSCREEN" <linux-input@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>
Subject:
 回复: [EXT] Re: [PATCH] input: goodix: add poll mode for goodix touchscreen

Hi Dmitry,

Thanks for your comment.
I didn't notice there is polling infrastructure before. Thanks for the remind. I already change to use polling infrastructure in v2.

Best Regards.
Joseph

-----邮件原件-----
发件人: Dmitry Torokhov <dmitry.torokhov@...il.com> 
发送时间: Tuesday, May 20, 2025 12:23 AM
收件人: Joseph Guo <qijian.guo@....com>
抄送: Bastien Nocera <hadess@...ess.net>; Hans de Goede <hdegoede@...hat.com>; open list:GOODIX TOUCHSCREEN <linux-input@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>
主题: [EXT] Re: [PATCH] input: goodix: add poll mode for goodix touchscreen

[You don't often get email from dmitry.torokhov@...il.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button


Hi Joseph,

On Mon, May 19, 2025 at 05:57:43PM +0900, Joseph Guo wrote:
> goodix touchscreen only support interrupt mode by default.
> Some panels like waveshare panel which is widely used on raspeberry pi 
> don't have interrupt pins and only work on i2c poll mode.
> The waveshare panel 7inch panel use goodix gt911 touchscreen chip.
>
> Update goodix touchscreen to support both interrupt and poll mode.
>
> Signed-off-by: Joseph Guo <qijian.guo@....com>
> ---
>  drivers/input/touchscreen/goodix.c | 69 
> +++++++++++++++++++++++++++---  drivers/input/touchscreen/goodix.h |  
> 4 ++
>  2 files changed, 67 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c 
> b/drivers/input/touchscreen/goodix.c
> index aaf79ac50004..87991b56494d 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -47,6 +47,7 @@
>  #define RESOLUTION_LOC               1
>  #define MAX_CONTACTS_LOC     5
>  #define TRIGGER_LOC          6
> +#define POLL_INTERVAL_MS             17      /* 17ms = 60fps */
>
>  /* Our special handling for GPIO accesses through ACPI is x86 
> specific */  #if defined CONFIG_X86 && defined CONFIG_ACPI @@ -497,6 
> +498,23 @@ static void goodix_process_events(struct goodix_ts_data *ts)
>       input_sync(ts->input_dev);
>  }
>
> +static void goodix_ts_irq_poll_timer(struct timer_list *t) {
> +     struct goodix_ts_data *ts = from_timer(ts, t, timer);
> +
> +     schedule_work(&ts->work_i2c_poll);
> +     mod_timer(&ts->timer, jiffies + 
> +msecs_to_jiffies(POLL_INTERVAL_MS));
> +}

Why are you not suing the existing polling infrastructure (input_setup_polling())?

Thanks.

--
Dmitry