linux-kernel - Re: [PATCH v2] dt-bindings:iio:adc:st,spear600-adc: txt to yaml format conversion.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250521-grew-rotting-7081d2939477@spud>
Date: Wed, 21 May 2025 16:50:18 +0100
From: Conor Dooley <conor@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, jic23@...nel.org,
	krzk+dt@...nel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, robh@...nel.org,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH v2] dt-bindings:iio:adc:st,spear600-adc: txt to yaml
 format conversion.

On Tue, May 20, 2025 at 05:43:45PM -0300, Rodrigo Gobbi wrote:
> > Sounds like it's a 4-bit register where the samples is (1 + written value),
> > and the property is expected to be written directly to the register.
> > I'd then expect the property to be min 0, default 0, max 127. If you
> > write 128 to the register, you'll accidentally set the external vref
> > bit. I'd maybe go as far as &ing the value to make sure out of range
> > stuff is not permitted?
> 
> Well, it looks like 4bit as you said (bits 5,6,7 and 8) and 9th bit is vref.
> But, in this case, it looks to me that we can only configure 0x15 as a max value,
> (didn`t see that before) which doesn`t fit the datasheet sentence that I`ve mentioned before:
> 
> "Programmable averaging of results from 1 (No averaging) up to 128"
> 
> I mean, I`m not sure how many samples are configured when using
> SPEAR_ADC_STATUS_AVG_SAMPLE(0xD) since we don`t have a register map describing
> how it encodes that internally. Maybe we can change the requirements for this field to be
> min 0, default 0, max 15?

I think so, since that matches the behaviour that's been there in the
driver since the property was introduced.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)