linux-kernel - Re: [PATCH v2 4/9] dt-bindings: mfd: add pf1550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC38a4hbxPqsUpXS@fedora>
Date: Wed, 21 May 2025 12:16:43 -0400
From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sebastian Reichel <sre@...nel.org>, Robin Gong <yibin.gong@....com>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-imx@....com, linux-input@...r.kernel.org,
	Abel Vesa <abelvesa@...ux.com>, Abel Vesa <abel.vesa@....com>,
	Robin Gong <b38343@...escale.com>,
	Enric Balletbo Serra <eballetbo@...il.com>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 4/9] dt-bindings: mfd: add pf1550

On Sat, May 17, 2025 at 01:16:38PM +0200, Krzysztof Kozlowski wrote:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  regulators:
> > +    $ref: /schemas/regulator/pf1550.yaml
> > +
> > +  charger:
> > +    $ref: /schemas/power/supply/pf1550_charger.yaml
> > +
> > +  onkey:
> > +    $ref: /schemas/input/pf1550_onkey.yaml
> 
> This makes merging via separate trees not possible...
> 
> Just fold everything here, drop compatibles and then put binding in the
> regulator. Unless children are re-usable which would justify
> compatibles, but then please provide arguments for that.

Yes, compatibles are not needed for the children. For adding binding to the
regulator, did you mean for all children: charger and onkey included? So,
replacing the separate yaml for all children with bindings in the mfd yaml?

Thanks,
Sam