linux-kernel - Re: [PATCH v7 1/6] dt-bindings: arm: qcom: Add bindings for QCS9075 SOC based board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9df2f9f3-289f-4916-a293-ad5d97d530fe@kernel.org>
Date: Wed, 21 May 2025 18:26:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wasim Nazir <quic_wasimn@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...cinc.com, kernel@....qualcomm.com
Subject: Re: [PATCH v7 1/6] dt-bindings: arm: qcom: Add bindings for QCS9075
 SOC based board

On 21/05/2025 17:35, Wasim Nazir wrote:
> On Wed, May 21, 2025 at 04:20:53PM +0200, Krzysztof Kozlowski wrote:
>> On 21/05/2025 16:08, Wasim Nazir wrote:
>>> QCS9075 is compatible Industrial-IOT grade variant of SA8775p SOC.
>>> Unlike QCS9100, it doesn't have safety monitoring feature of
>>> Safety-Island(SAIL) subsystem, which affects thermal management.
>>>
>>> qcs9075-iq-9075-evk board is based on QCS9075 SOC.
>>>
>>> Signed-off-by: Wasim Nazir <quic_wasimn@...cinc.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>
>> This was already acked twice by two DT maintainers. Apparently we need
>> the third one.
> 
> The previous acknowledgment has been removed due to changes in the code.
> Since, here I have removed the som compatible so though of getting it
> reviewed again. Som compatible is removed to make it align with other
> sa8775p & its derivative targets which we are trying to refactor along with
> Ride changes in other series.

Nothing was explained in cover letter and dropping tags needs explicit
mentioning. Nothing explained about first tag being dropped, either!
Read really carefully submitting patches and your internal guideline
before sending patches.

But that was not about it. It was about us spending 1 or 5 minutes on
your patch every time, because you send something not ready which your
company decides to change thus we need to spend time again, and then you
change it again, which we need to spend time again... do you get the point?

That is not fair. Your marketing changes should not cause more effort on
us. And this is not the first time.

At least I do not agree on that. Anyway, I explained my point of view to
Bjorn and Konrad. I am not going to review this. Maybe you will be lucky
with the third DT maintainer.

Best regards,
Krzysztof