linux-kernel - Re: [PATCH v7 0/6] Introduce CET supervisor state support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC4Gh0YMxFzNVws1@google.com>
Date: Wed, 21 May 2025 09:59:51 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Chao Gao <chao.gao@...el.com>
Cc: Dave Hansen <dave.hansen@...el.com>, Ingo Molnar <mingo@...nel.org>, x86@...nel.org, 
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org, tglx@...utronix.de, 
	pbonzini@...hat.com, peterz@...radead.org, rick.p.edgecombe@...el.com, 
	weijiang.yang@...el.com, john.allen@....com, bp@...en8.de, 
	chang.seok.bae@...el.com, xin3.li@...el.com, 
	Aruna Ramakrishna <aruna.ramakrishna@...cle.com>, Dave Hansen <dave.hansen@...ux.intel.com>, 
	Eric Biggers <ebiggers@...gle.com>, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>, 
	Kees Cook <kees@...nel.org>, Maxim Levitsky <mlevitsk@...hat.com>, 
	Mitchell Levy <levymitchell0@...il.com>, Nikolay Borisov <nik.borisov@...e.com>, 
	Oleg Nesterov <oleg@...hat.com>, Samuel Holland <samuel.holland@...ive.com>, 
	Sohil Mehta <sohil.mehta@...el.com>, Stanislav Spassov <stanspas@...zon.de>, 
	Uros Bizjak <ubizjak@...il.com>, Vignesh Balasubramanian <vigbalas@....com>, Zhao Liu <zhao1.liu@...el.com>
Subject: Re: [PATCH v7 0/6] Introduce CET supervisor state support

On Wed, May 21, 2025, Chao Gao wrote:
> On Fri, May 16, 2025 at 08:20:54AM -0700, Dave Hansen wrote:
> >On 5/15/25 08:41, Ingo Molnar wrote:
> >> * Chao Gao <chao.gao@...el.com> wrote:
> >>> I kindly request your consideration for merging this series. Most of 
> >>> patches have received Reviewed-by/Acked-by tags.
> >> I don't see anything objectionable in this series.
> >> 
> >> The upcoming v6.16 merge window is already quite crowded in terms of 
> >> FPU changes, so I think at this point we are looking at a v6.17 merge, 
> >> done shortly after v6.16-rc1 if everything goes well. Dave, what do you 
> >> think?
> >
> >It's getting into shape, but it has a slight shortage of reviews. For
> >now, it's an all-Intel patch even though I _thought_ AMD had this
> >feature too. It's also purely for KVM and has some suggested-by's from
> >Sean, but no KVM acks on it.
> >
> >Sean is not exactly the quiet type about things, but it always warms me
> >heart to see an acked-by accompanying a suggested-by because it
> >indicates that the suggestion was heard and implemented properly.
> 
> Hi Sean, John,
> 
> Based on Dave's feedback, could you please review this series and provide your
> reviewed-by/acked-by if appropriate?

The initialization of default features is a bit gnarly and I think can be improved
without too much fuss, but otherwise this looks good.