linux-kernel - Re: [PATCH v4] PCI: Prevent power state transition of erroneous device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bddf9bb-0c57-4823-bef1-e5bdf16ef5f7@kernel.org>
Date: Wed, 21 May 2025 12:06:21 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Lukas Wunner <lukas@...ner.de>, Denis Benato <benato.denis96@...il.com>
Cc: Raag Jadav <raag.jadav@...el.com>, rafael@...nel.org,
 mahesh@...ux.ibm.com, oohall@...il.com, bhelgaas@...gle.com,
 linux-pci@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
 aravind.iddamsetty@...ux.intel.com
Subject: Re: [PATCH v4] PCI: Prevent power state transition of erroneous
 device

On 5/21/25 08:39, Lukas Wunner wrote:
> On Tue, May 20, 2025 at 07:22:04PM +0200, Denis Benato wrote:
>> This is the very same exact kernel, minus the patch in question:
>> https://pastebin.com/rwMYgG7C
>>
>> Both previous kernel and this one have CONFIG_PCI_DEBUG=y.
> 
> This log excerpt shows that the ASMedia Thunderbolt controller
> below the Intel Thunderbolt controller couldn't be enumerated
> on boot:
> 
> mag 20 18:42:20 denis-pc kernel: pci 0000:03:01.0: broken device, retraining non-functional downstream link at 2.5GT/s
> mag 20 18:42:20 denis-pc kernel: pci 0000:03:01.0: retraining failed
> 
> However, the Thunderbolt tunnel goes up and the devices are
> enumerated 24 seconds later:
> 
> mag 20 18:42:44 denis-pc kernel: pcieport 0000:03:01.0: pciehp: Slot(1-1): Card present
> mag 20 18:42:44 denis-pc kernel: pcieport 0000:03:01.0: pciehp: Slot(1-1): Link Up
> 
> Thanks,
> 
> Lukas

Are you suggesting that the training failure is why there was an error?

If so maybe that should be cleared when it does eventually train.