linux-kernel - Re: [PATCH v1 1/1] local_lock: Minor improvements of local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ6HWG7Dtw=UpKbvyRh=SjE0X6Bj9zHGd15crbRH8bybGrUEow@mail.gmail.com>
Date: Wed, 21 May 2025 14:40:27 -0300
From: Leonardo Bras Soares Passos <leobras@...hat.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Jakub Kicinski <kuba@...nel.org>, "Peter Zijlstra (Intel)" <peterz@...radead.org>, 
	Alexei Starovoitov <ast@...nel.org>, Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] local_lock: Minor improvements of local_trylock*() documentation

Hi Sebastian,

On Mon, May 12, 2025 at 7:43 AM Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
>
> On 2025-05-05 14:02:44 [-0300], Leonardo Bras wrote:
> > Fix local_trylock_init() documentation, as it was mentioning the non-try
> > helper instead, and use the opportunity to make clear the try_lock*() needs
> > to receive a local_trylock_t variable as parameter.
> >
> > Signed-off-by: Leonardo Bras <leobras@...hat.com>
> …
> > --- a/include/linux/local_lock.h
> > +++ b/include/linux/local_lock.h
> > @@ -45,38 +45,38 @@
> >  /**
> >   * local_unlock_irqrestore - Release a per CPU local lock and restore
> >   *                         interrupt flags
> >   * @lock:    The lock variable
> >   * @flags:      Interrupt flags to restore
> >   */
> >  #define local_unlock_irqrestore(lock, flags)                 \
> >       __local_unlock_irqrestore(lock, flags)
> >
> >  /**
> > - * local_lock_init - Runtime initialize a lock instance
> > + * local_trylock_init - Runtime initialize a local_trylock instance
>
> If you replace "lock instance" please use local_trylock_t instead
> "local_trylock"

Will do

>
> Other than that,
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Thanks!
Leo

>
> >   */
> >  #define local_trylock_init(lock)     __local_trylock_init(lock)
>
> …
>
> Sebastian
>