linux-kernel - Re: [PATCH] mmc: sdhci-sprd: Add error handling for sdhci_runtime_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f0b7332-477b-4028-b663-09803718e8d9@linux.alibaba.com>
Date: Wed, 21 May 2025 11:22:18 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Wentao Liang <vulab@...as.ac.cn>, adrian.hunter@...el.com,
 ulf.hansson@...aro.org, orsonzhai@...il.com, zhang.lyra@...il.com
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-sprd: Add error handling for
 sdhci_runtime_suspend_host()



On 2025/5/19 20:33, Wentao Liang wrote:
> The dhci_sprd_runtime_suspend() calls sdhci_runtime_suspend_host() but
> does not handle the return value. A proper implementation can be found
> in sdhci_am654_runtime_suspend().
> 
> Add error handling for sdhci_runtime_suspend_host(). Return the error
> code if the suspend fails.
> 
> Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
> Cc: stable@...r.kernel.org # v4.20
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

LGTM.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/mmc/host/sdhci-sprd.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index db5e253b0f79..dd41427e973a 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -922,9 +922,12 @@ static int sdhci_sprd_runtime_suspend(struct device *dev)
>   {
>   	struct sdhci_host *host = dev_get_drvdata(dev);
>   	struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);
> +	int ret;
>   
>   	mmc_hsq_suspend(host->mmc);
> -	sdhci_runtime_suspend_host(host);
> +	ret = sdhci_runtime_suspend_host(host);
> +	if (ret)
> +		return ret;
>   
>   	clk_disable_unprepare(sprd_host->clk_sdio);
>   	clk_disable_unprepare(sprd_host->clk_enable);