linux-kernel - Re: [PATCH v7 4/6] arm64: dts: qcom: Add support for qcs9075 IQ-9075-EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC4pnz6XgT/RqfLU@hu-wasimn-hyd.qualcomm.com>
Date: Thu, 22 May 2025 00:59:35 +0530
From: Wasim Nazir <quic_wasimn@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, <kernel@....qualcomm.com>
Subject: Re: [PATCH v7 4/6] arm64: dts: qcom: Add support for qcs9075
 IQ-9075-EVK

On Wed, May 21, 2025 at 06:57:03PM +0200, Konrad Dybcio wrote:
> On 5/21/25 4:08 PM, Wasim Nazir wrote:
> > Add initial device tree support for IQ-9075-EVK board,
> > based on Qualcomm's QCS9075 SOC.
> > 
> > Implement basic changes to enable boot to shell.
> > 
> > Signed-off-by: Wasim Nazir <quic_wasimn@...cinc.com>
> > ---
> 
> [...]
> 
> two nits:
> 
> > +&tlmm {
> > +	qup_uart10_default: qup-uart10-state {
> > +		pins = "gpio46", "gpio47";
> > +		function = "qup1_se3";
> > +	};
> 
> Feel free to move it over to sa8775p.dtsi

Thanks for pointing it out. Will move this to SOC file.

> 
> > +};
> > +
> > +&uart10 {
> > +	compatible = "qcom,geni-debug-uart";
> > +	pinctrl-0 = <&qup_uart10_default>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
> 
> Please keep a newline before 'status'

Sure.

> 
> Konrad

Regards,
Wasim