linux-kernel - Re: [PATCH v2] rbd: replace strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKWSiC6WMCsVv_=EUGFaScypXmn3yJEC5xdRN37DC9xo=VVh0A@mail.gmail.com>
Date: Thu, 22 May 2025 01:19:22 +0530
From: Siddarth Gundu <siddarthsgml@...il.com>
To: Jens Axboe <axboe@...nel.dk>
Cc: Alex Elder <elder@...e.org>, idryomov@...il.com, dongsheng.yang@...ystack.cn, 
	ceph-devel@...r.kernel.org, linux-block@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rbd: replace strcpy() with strscpy()

On Tue, May 20, 2025 at 10:26 PM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 5/20/25 10:44 AM, Alex Elder wrote:
> > On 5/19/25 1:38 AM, Siddarth Gundu wrote:
> >> strcpy() is deprecated; use strscpy() instead.
> >>
> >> Both the destination and source buffer are of fixed length
> >> so strscpy with 2-arguments is used.
> >>
> >> Introduce a typedef for cookie array to improve code clarity.
> >>
> >> Link: https://github.com/KSPP/linux/issues/88
> >> Signed-off-by: Siddarth Gundu <siddarthsgml@...il.com>
> >> ---
> >> changes since v1
> >> - added a typedef for cookie arrays
> >>
> >> About the typedef: I was a bit hesitant to add it since the kernel
> >> style guide is against adding new typedef but I wanted to follow
> >> the review feedback for this.
> >
> > I personally think the typedef here is the appropriate.  But
> > it's really up to Ilya whether he likes this approach.  Get
> > his input before you do more.
>
> In any case, this should be 2 patches at that point, not collapsed
> into one patch.

Understood. If the typedef approach is a go after Ilya's feedback,
I'll split the changes into two separate patches as you suggested.
Thanks a lot for the review.

--
With Gratitude
Siddarth Gundu