linux-kernel - Re: [PATCH] cpufreq: Replace magic number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0haaPh7E15mN-mFuA4tktwWh0eC2AZBzf3_3BTbSz833g@mail.gmail.com>
Date: Wed, 21 May 2025 22:20:43 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>, Bowen Yu <yubowen8@...wei.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linuxarm@...wei.com, zhanjie9@...ilicon.com, jonathan.cameron@...wei.com, 
	lihuisong@...wei.com, zhenglifeng1@...wei.com, cenxinghai@...artners.com
Subject: Re: [PATCH] cpufreq: Replace magic number

On Mon, May 19, 2025 at 12:02 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 19-05-25, 15:09, Bowen Yu wrote:
> > Setting the length of str_governor with a magic number could cause
> > overflow when max length increases, it is better to use the defined
> > macro in this case.
> >
> > Signed-off-by: Bowen Yu <yubowen8@...wei.com>
> > ---
> >  drivers/cpufreq/cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 0c842edd1a76..a3a376f030f0 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -809,7 +809,7 @@ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf)
> >  static ssize_t store_scaling_governor(struct cpufreq_policy *policy,
> >                                       const char *buf, size_t count)
> >  {
> > -     char str_governor[16];
> > +     char str_governor[CPUFREQ_NAME_LEN];
> >       int ret;
> >
> >       ret = sscanf(buf, "%15s", str_governor);
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied as 6.16 material, thanks!