linux-kernel - Re: [PATCH] cpufreq: Update sscanf() to kstrtouint()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i8tF8iGHfgX84ro7kFiYOq5kVSyfEoj_KE1mf=CN5SPw@mail.gmail.com>
Date: Wed, 21 May 2025 22:28:56 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>, Bowen Yu <yubowen8@...wei.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linuxarm@...wei.com, zhanjie9@...ilicon.com, jonathan.cameron@...wei.com, 
	lihuisong@...wei.com, zhenglifeng1@...wei.com, cenxinghai@...artners.com
Subject: Re: [PATCH] cpufreq: Update sscanf() to kstrtouint()

On Mon, May 19, 2025 at 12:04 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 19-05-25, 15:09, Bowen Yu wrote:
> > In store_scaling_setspeed(), sscanf is still used to read to sysfs.
> > Newer kstrtox provide more features including overflow protection,
> > better errorhandling and allows for other systems of numeration. It
> > is therefore better to update sscanf() to kstrtouint().
> >
> > Signed-off-by: Bowen Yu <yubowen8@...wei.com>
> > ---
> >  drivers/cpufreq/cpufreq.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index be727da0be4d..0c842edd1a76 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -920,9 +920,9 @@ static ssize_t store_scaling_setspeed(struct cpufreq_policy *policy,
> >       if (!policy->governor || !policy->governor->store_setspeed)
> >               return -EINVAL;
> >
> > -     ret = sscanf(buf, "%u", &freq);
> > -     if (ret != 1)
> > -             return -EINVAL;
> > +     ret = kstrtouint(buf, 0, &freq);
> > +     if (ret)
> > +             return ret;
> >
> >       policy->governor->store_setspeed(policy, freq);
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied as 6.16 material, thanks!