Message-Id: <20250521204310.it.500-kees@kernel.org>
Date: Wed, 21 May 2025 13:46:08 -0700
From: Kees Cook <kees@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Kees Cook <kees@...nel.org>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>,
	Chaitanya Kulkarni <kch@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Mike Christie <michael.christie@...cle.com>,
	Max Gurtovoy <mgurtovoy@...dia.com>,
	Maurizio Lombardi <mlombard@...hat.com>,
	Dmitry Bogdanov <d.bogdanov@...ro.com>,
	Mingzhe Zou <mingzhe.zou@...ystack.cn>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Simon Horman <horms@...nel.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Cosmin Ratiu <cratiu@...dia.com>,
	Lei Yang <leiyang@...hat.com>,
	Ido Schimmel <idosch@...dia.com>,
	Samuel Mendoza-Jonas <sam@...dozajonas.com>,
	Paul Fertser <fercerpav@...il.com>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Hayes Wang <hayeswang@...ltek.com>,
	Douglas Anderson <dianders@...omium.org>,
	Grant Grundler <grundler@...omium.org>,
	Jay Vosburgh <jv@...sburgh.net>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>,
	Dexuan Cui <decui@...rosoft.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Jason Wang <jasowang@...hat.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Kory Maincent <kory.maincent@...tlin.com>,
	Maxim Georgiev <glipus@...il.com>,
	Aleksander Jan Bajkowski <olek2@...pl>,
	Philipp Hahn <phahn-oss@....de>,
	Eric Biggers <ebiggers@...gle.com>,
	Ard Biesheuvel <ardb@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Xiao Liang <shaw.leon@...il.com>,
	linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org,
	linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-wpan@...r.kernel.org,
	linux-usb@...r.kernel.org,
	linux-hyperv@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH net-next v2 0/8] net: Convert dev_set_mac_address() to struct sockaddr_storage

 v2:
  - add conversion of dev_set_mac_address_user() (kuniyu)
  - fix missed sockaddr/sockaddr_storage conversion (kuba)
 v1: https://lore.kernel.org/all/20250520222452.work.063-kees@kernel.org/

Hi,

As part of the effort to allow the compiler to reason about object sizes,
we need to deal with the problematic variably sized struct sockaddr,
which has no internal runtime size tracking. In much of the network
stack the use of struct sockaddr_storage has been adopted. Continue the
transition toward this for more of the internal APIs. Specifically:

- inet_addr_is_any()
- netif_set_mac_address()
- dev_set_mac_address()
- dev_set_mac_address_user()

Only a few callers of dev_set_mac_address() needed adjustment; all others
were already using struct sockaddr_storage internally.

-Kees

Kees Cook (8):
  net: core: Convert inet_addr_is_any() to sockaddr_storage
  net: core: Switch netif_set_mac_address() to struct sockaddr_storage
  net/ncsi: Use struct sockaddr_storage for pending_mac
  ieee802154: Use struct sockaddr_storage with dev_set_mac_address()
  net: usb: r8152: Convert to use struct sockaddr_storage internally
  net: core: Convert dev_set_mac_address() to struct sockaddr_storage
  rtnetlink: do_setlink: Use struct sockaddr_storage
  net: core: Convert dev_set_mac_address_user() to use struct
    sockaddr_storage

 include/linux/inet.h                |  2 +-
 include/linux/netdevice.h           |  6 ++--
 net/ncsi/internal.h                 |  2 +-
 drivers/net/bonding/bond_alb.c      |  8 ++---
 drivers/net/bonding/bond_main.c     | 15 ++++-----
 drivers/net/hyperv/netvsc_drv.c     |  6 ++--
 drivers/net/macvlan.c               | 18 +++++-----
 drivers/net/tap.c                   | 14 +++++---
 drivers/net/team/team_core.c        |  2 +-
 drivers/net/tun.c                   |  8 ++++-
 drivers/net/usb/r8152.c             | 52 +++++++++++++++--------------
 drivers/nvme/target/rdma.c          |  2 +-
 drivers/nvme/target/tcp.c           |  2 +-
 drivers/target/iscsi/iscsi_target.c |  2 +-
 net/core/dev.c                      | 11 +++---
 net/core/dev_api.c                  | 11 +++---
 net/core/dev_ioctl.c                |  6 ++--
 net/core/rtnetlink.c                | 19 +++--------
 net/core/utils.c                    |  8 ++---
 net/ieee802154/nl-phy.c             |  6 ++--
 net/ncsi/ncsi-rsp.c                 | 18 +++++-----
 21 files changed, 109 insertions(+), 109 deletions(-)

-- 
2.34.1

Powered by blists - more mailing lists