linux-kernel - [PATCH net-next v2 4/8] ieee802154: Use struct sockaddr_storage with dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250521204619.2301870-4-kees@kernel.org>
Date: Wed, 21 May 2025 13:46:12 -0700
From: Kees Cook <kees@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Kees Cook <kees@...nel.org>,
	"Gustavo A . R . Silva" <gustavoars@...nel.org>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	linux-wpan@...r.kernel.org,
	netdev@...r.kernel.org,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>,
	Chaitanya Kulkarni <kch@...dia.com>,
	Mike Christie <michael.christie@...cle.com>,
	Max Gurtovoy <mgurtovoy@...dia.com>,
	Maurizio Lombardi <mlombard@...hat.com>,
	Dmitry Bogdanov <d.bogdanov@...ro.com>,
	Mingzhe Zou <mingzhe.zou@...ystack.cn>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Cosmin Ratiu <cratiu@...dia.com>,
	Lei Yang <leiyang@...hat.com>,
	Ido Schimmel <idosch@...dia.com>,
	Samuel Mendoza-Jonas <sam@...dozajonas.com>,
	Paul Fertser <fercerpav@...il.com>,
	Hayes Wang <hayeswang@...ltek.com>,
	Douglas Anderson <dianders@...omium.org>,
	Grant Grundler <grundler@...omium.org>,
	Jay Vosburgh <jv@...sburgh.net>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>,
	Dexuan Cui <decui@...rosoft.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Jason Wang <jasowang@...hat.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Kory Maincent <kory.maincent@...tlin.com>,
	Maxim Georgiev <glipus@...il.com>,
	Aleksander Jan Bajkowski <olek2@...pl>,
	Philipp Hahn <phahn-oss@....de>,
	Eric Biggers <ebiggers@...gle.com>,
	Ard Biesheuvel <ardb@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Xiao Liang <shaw.leon@...il.com>,
	linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org,
	linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	linux-hyperv@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH net-next v2 4/8] ieee802154: Use struct sockaddr_storage with dev_set_mac_address()

Switch to struct sockaddr_storage for calling dev_set_mac_address(). Add
a temporary cast to struct sockaddr, which will be removed in a
subsequent patch.

Acked-by: Gustavo A. R. Silva <gustavoars@...nel.org>
Signed-off-by: Kees Cook <kees@...nel.org>
---
Cc: Alexander Aring <alex.aring@...il.com>
Cc: Stefan Schmidt <stefan@...enfreihafen.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>
Cc: <linux-wpan@...r.kernel.org>
Cc: <netdev@...r.kernel.org>
---
 net/ieee802154/nl-phy.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c
index 359249ab77bf..ee2b190e8e0d 100644
--- a/net/ieee802154/nl-phy.c
+++ b/net/ieee802154/nl-phy.c
@@ -224,17 +224,17 @@ int ieee802154_add_iface(struct sk_buff *skb, struct genl_info *info)
 	dev_hold(dev);
 
 	if (info->attrs[IEEE802154_ATTR_HW_ADDR]) {
-		struct sockaddr addr;
+		struct sockaddr_storage addr;
 
-		addr.sa_family = ARPHRD_IEEE802154;
-		nla_memcpy(&addr.sa_data, info->attrs[IEEE802154_ATTR_HW_ADDR],
+		addr.ss_family = ARPHRD_IEEE802154;
+		nla_memcpy(&addr.__data, info->attrs[IEEE802154_ATTR_HW_ADDR],
 			   IEEE802154_ADDR_LEN);
 
 		/* strangely enough, some callbacks (inetdev_event) from
 		 * dev_set_mac_address require RTNL_LOCK
 		 */
 		rtnl_lock();
-		rc = dev_set_mac_address(dev, &addr, NULL);
+		rc = dev_set_mac_address(dev, (struct sockaddr *)&addr, NULL);
 		rtnl_unlock();
 		if (rc)
 			goto dev_unregister;
-- 
2.34.1